Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 1RM calculator #72

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

senier
Copy link
Contributor

@senier senier commented Dec 29, 2024

Prototype for 1RM calculator. Please let me know what you think.

@treiher
Copy link
Owner

treiher commented Jan 3, 2025

That's a nice extension. Here are some thoughts:

On the training session page:

  • A modal overlay could be a bit nicer as the currently used dropdown, because all other information on the page would be faded out. It also centers the information on the screen, so that no scrolling is needed.
  • Just going down to 50% 1RM could be enough. Who wants to do more than 30 reps?
  • It could be useful to have 5% steps.
  • The info button could be hidden if there is no information to show.
  • It could be useful to also have a 1RM calculator where a custom value could be entered. We could add a button for that to the navigation bar, as it is done for the Stopwatch/Metronome/Timer overlay. An alternative could be adding it to the hamburger menu, so that the calculator could be used on every page.

On the exercise page:

  • The 1RM chart: The current implementation leads to steps and gaps in the average graph (see example below). A "value-based" centered moving average (instead of the currently used interval-based one) would lead to nicer charts. I also don't see the advantage of using a fixed interval for the average here. Just using a simple average like in the weight chart would be most consistent with the other charts on the exercise page.

image

  • The fact that the 1RM table has a title is inconsistent. Other parts of the page don't have titles.
  • The meaning of the date above the 1RM table is unclear.
  • Maybe it would be better to remove the 1RM table and just add a "Avg. 1RM" column to the training session table. The X% 1RM values are not interesting to me here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants