Enable ruff-pre-commit for third_party/nvidia
#5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
commented
Jan 12, 2025
| @@ -313,7 +313,7 @@ def make_llir(src, metadata, options, capability): | |||
| llvm.init_targets() | |||
| context = llvm.context() | |||
| if os.environ.get("TRITON_ENABLE_ASAN", "0") == "1": | |||
| raise ASANError( | |||
There was a problem hiding this comment.
ASANError is not defined
anmyachev
commented
Jan 12, 2025
| @@ -239,7 +239,7 @@ def make_ttgir(mod, metadata, opt, capability): | |||
| # Set up Diagnostic | |||
| if os.environ.get("MLIR_ENABLE_REMARK", "0") == "1": | |||
| srcMgr = llvm.source_mgr() | |||
| diag = ir.source_mgr_diag(srcMgr, mod.context) | |||
There was a problem hiding this comment.
Test failure looks real, probably the lifetime of this variable controls the diagnostics setting.
There was a problem hiding this comment.
Could you rerun CI?
There was a problem hiding this comment.
Everything seems to be fine now :)
There was a problem hiding this comment.
I refactored this in my PR as well #5581. I guess it doesn't depend on the lifetime of the variable. Previously it calls a constructor for the SourceMgrDiagnosticHandler, which registers the handler into the MLIRContext.
ptillet
approved these changes
Jan 12, 2025
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
ruff-for-nvidia
branch
from
3de597a to
69f7732
Compare
sfzhu93
pushed a commit
to sfzhu93/triton
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.