[WIP] [AMD] Remove "remove unsupported conversions" pass #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cases are covered by TritonGPUReduceDataDuplication pass OptimizeLDSUsage passes. The rest of cases is not needed anymore, because all combinations of layouts are supported.
binarman
changed the title
|
WIP, because I need to check this change does not degrade performance |
binarman
commented
Jan 22, 2025
| @@ -1,33 +0,0 @@ | |||
| // RUN: triton-opt %s --split-input-file --decompose-unsupported-amd-conversions=arch=gfx942 | FileCheck %s | |||
There was a problem hiding this comment.
Removed these tests, because these cases are covered by LDS optimize pass, which has it's own tests.
binarman
commented
Jan 22, 2025
| @@ -40,3 +40,75 @@ module attributes {"ttg.target" = "hip:gfx940", "ttg.num-ctas" = 1 : i32, "ttg.n | |||
| tt.return | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is part of decompose-unsupported-conversions.mlir testsuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cases are covered by TritonGPUReduceDataDuplication and OptimizeLDSUsage passes.
The rest of cases is not needed anymore, because all combinations of layouts are supported.