Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper parameters for some s3 bucket resources #408

Merged
merged 11 commits into from
Jan 15, 2025

Conversation

esacteksab
Copy link
Contributor

  • chore: override_policy_document and source_policy_document fixed in this release
  • chore: renovate renovate config
  • chore: output the target prefix allowing it to be used in terraform-aws-logs
  • docs: examples are more accurate
  • chore: pinning shared action
  • chore: block tf lock file
  • chore: pre-commit autoupdate
  • chore: use valid parameter and get rid of workaround for source_policy_document and override_policy_document
  • docs: terraform_docs

TF Issue 24366
TF Issue 22959

Copy link

@clint-truss clint-truss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I don't think this would adversely impact other systems using this since the changes are additive. The one change would be if someone were using an ELB and had worked around the fact that the resources were supposed to be a list, but then they'd probably be happy to remove that work around.

@esacteksab esacteksab merged commit fb3466c into main Jan 15, 2025
1 check passed
@esacteksab esacteksab deleted the barry-update-things branch January 15, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants