Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Place 👨‍💻 #14

Merged
merged 21 commits into from
Mar 1, 2024
Merged

Add Place 👨‍💻 #14

merged 21 commits into from
Mar 1, 2024

Conversation

tsheporamantso
Copy link
Owner

@tsheporamantso tsheporamantso commented Mar 1, 2024 •
edited by George7h
Loading

Add Place 👨‍💻

On this milestone, 🗿 I managed to implement the following

@tsheporamantso
Add addPlaceReducer to store.js
47e5719
@tsheporamantso
Add addPlaceSlice to Redux places
f9beb1e
@tsheporamantso
Rearranged imports and updated addPlaceSlice in Redux
2c99c70
@tsheporamantso
Fix typo in addPlaceReducer key
969a903
@tsheporamantso
Add AddPlace component to routes
10d52e0
@tsheporamantso
Add AddPlace component
f769dff
@tsheporamantso
Update link to Add Place in Navigation
bd20221
@tsheporamantso
Remove unused code and images from Home component
d6813ef
@tsheporamantso
Refactor AddPlace component to include form container and error messa…
45a55eb 
…ge styling className
@tsheporamantso
Commented out unnecessary code in Navigation.js
a545f0f
@tsheporamantso
Remove unnecessary h4 tag in Layout component
7e147e3
@tsheporamantso
Import Styling component
e82a4bf
@tsheporamantso
Add styles for AddPlace form
dc4779c
@tsheporamantso
Correct styleling errors
dea2cdb
@tsheporamantso
Merge branch 'dev' into add-place
d3d3e17
@tsheporamantso
Resolve lyout.js conflicts
68bfb36
@tsheporamantso
Resolve Navigation.js conflicts
6329706
@tsheporamantso
Merge branch 'add-place' of github.com:tsheporamantso/final-capstone-…
229990b 
…react-front-end into add-place
@tsheporamantso tsheporamantso mentioned this pull request Mar 1, 2024
Merged
3 tasks
@tsheporamantso tsheporamantso linked an issue Mar 1, 2024 that may be closed by this pull request
[3pt] Add item #5
Closed
@tsheporamantso tsheporamantso requested a review from George7h March 1, 2024 15:54
George7h
George7h approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@George7h George7h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tsheporamantso,

Status Approve 👍 😁 🎉

The project is completed and there's nothing more to say other than to merge 🚢

Highlights: 🟢

  • Correct Gitflow ✔️
  • No linter Errors ✔️
  • Descriptive commit messages ✔️
  • Implemented Form and Slice as expected ✔️
  • Well done in Linking the front-end repo to the back-end repo ✔️

@tsheporamantso tsheporamantso merged commit c2ced85 into dev Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George7h George7h George7h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3pt] Add item
2 participants
@tsheporamantso @George7h