Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete item πŸ‘¨β€πŸ’» #17

Merged
merged 17 commits into from
Mar 4, 2024
Merged

Delete item πŸ‘¨β€πŸ’» #17

merged 17 commits into from
Mar 4, 2024

Conversation

tsheporamantso
Copy link
Owner

@tsheporamantso tsheporamantso commented Mar 4, 2024

Delete item πŸ‘¨β€πŸ’»

On this Pull Request, I implemented the following,

Copy link
Collaborator

@evansnyamekye evansnyamekye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tsheporamantso

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights

  • All linters are passing βœ”οΈ
  • Professional PR description βœ”οΈ
  • Add deleteItemSlice and deletePlaceβœ”οΈ

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@tsheporamantso tsheporamantso merged commit 1490c14 into dev Mar 4, 2024
3 checks passed
@tsheporamantso tsheporamantso linked an issue Mar 4, 2024 that may be closed by this pull request
@tsheporamantso tsheporamantso removed the request for review from George7h March 5, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4pt] Delete Item
2 participants