Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor adjustments remove console statements #22

Merged
merged 25 commits into from
Mar 7, 2024
Merged

Minor adjustments remove console statements #22

merged 25 commits into from
Mar 7, 2024

Conversation

George7h
Copy link
Collaborator

@George7h George7h commented Mar 7, 2024

The following additional changes have been made:

  • use arrow function syntax in all components.
  • Fix form validations.
  • Fix prices formatting to show decimals.
  • Fix adding places and reservations to dispatch fetch actions of slices after submitting the forms.
  • Refactor the Deleteplace component to fetch places and fetch places after submitting the deletion.
  • Added confirmation to delete place.

George7h and others added 25 commits March 6, 2024 23:29
@George7h
Refactor App component to use arrow function syntax
9a9cb03
@George7h
Refactor AddReservation component to use arrow function syntax and ad…
67ceeb2 
…d form validation
@George7h
Refactor DetailsPage component to use arrow function syntax
29bd668
@George7h
Refactor Layout component
7529c96
@George7h
Refactor MyReservations component
0ae5b87
@George7h
Refactor Navigation component
9009025
@George7h
Refactor UserAuth component to use arrow function syntax
680f230
@George7h
Refactor UserSignUp component to use arrow function syntax
18d1e04
@George7h
Refactor PlacesList component to use arrow function syntax
af4c18a
@George7h
Refactor AddPlace component to use Redux for state management
494848f
@George7h
Fix form validation and input constraints
39cb16b
@George7h
Add fetchPlaces action to AddReservation component rather than using …
3a7fd88 
…the action in this component. Fix Redux architecture
@George7h
Fix price formatting in MyReservations component
f8ec832
@George7h
Fix formatting of price per night in PlaceList component
9bf2e04
@George7h
Add fetchPlaces after adding a new place
e59d604
@George7h
Add fetchReservations after adding a reservation
75eb0c2
@George7h
Refactor deleteplace component to render places on loading the compon…
60d34f2 
…ent then dispatch the placelist after successful deletion
@George7h
Add cursor pointer to button and remove cursor pointer from item details
0daccb0
@George7h
Remove unnecessary comments and improve form validation in AddReserva…
26ba368 
…tion component
@George7h
Remove comment
d8331b7
@George7h
Fix formatting of price per night in DetailsPage component
b1fa572
@George7h
Add error message for incomplete form submission
6ce119b
@George7h
Fix error message display in AddReservation component
b3405dc
@George7h
Add confirmation dialog for delete functionality and it's styling
62e99cd
@tsheporamantso
Change favicon
cc6a844
@George7h George7h requested a review from tsheporamantso March 7, 2024 09:21
tsheporamantso
tsheporamantso approved these changes Mar 7, 2024
View reviewed changes
Copy link
Owner

@tsheporamantso tsheporamantso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @George7h

Status Approved 🟢

Implemented all requirements requested by the reviewer, there's nothing more other than to merge the branch

@George7h George7h merged commit eabd8f0 into dev Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsheporamantso tsheporamantso tsheporamantso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@George7h @tsheporamantso