Fixing memory leak in req_setopt #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing memory leak when using req_setopt Approved-by: Marcin Wilk <marcin@foobot.io>
This was referenced May 23, 2018
Open
|
Thank @vtunr https://github.com/espressif/esp-idf/tree/master/components/esp_http_client |
|
Thanks, i didn't know it was on esp-idf yet. I'll switch to it. Tony |
|
esp_http_client is too heavy for simple tasks and has memory issues as well by the way... @tuanpmt Tuan, thanks for sharing anyway. @vtunr Tony, your fix seems working. I will leave code running for an hour to see if it is stable... i have http tasks coming every 5 seconds... will ping u with results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A memory leak could happen if req was null or there was no data when call req_setopt, because it was returning after the malloc.
Moving the malloc after the check solves the issue.