Shared schema #1080
Merged
Shared schema #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
haaawk
requested review from
MarinPostma,
Horusiath and
LucioFranco
and removed request for
MarinPostma and
Horusiath
Closed
MarinPostma
reviewed
Feb 24, 2024
| } | ||
| } | ||
| tx.execute( | ||
| "DELETE FROM namespace_configs WHERE namespace = ?", |
There was a problem hiding this comment.
shouldn't we also delete the link?
There was a problem hiding this comment.
The link is removed above in lines 381-386.
haaawk
force-pushed
the
shared_schema
branch
3 times, most recently
from
fe0b0c4 to
f372af5
Compare
|
Thanks for a great review @MarinPostma! I applied all your suggestions - please have another look. |
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
haaawk
force-pushed
the
shared_schema
branch
from
f372af5 to
924e6f6
Compare
MarinPostma
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #1055
It basically stores the relationship between shared schema db and databases linked to it:
The relationships are stored in form of shared_schema_links table in the meta store of a shared-schema db.
When we create a dependent db, we store a link in shared-schema.
When we destroy dependent db, we remove link from shared-schema.
When we destroy shared-schema, we first check if all dependent dbs are already destroyed. We fail if they don't.
Some known decifiencies:
Forking a db that links to a shared schema should add a link between a new fork and a shared schema but doesn't do it right now.