Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changes() and total_changes() functions and add tests #749

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

ben594
Copy link
Contributor

@ben594 ben594 commented Jan 20, 2025

#144

  • The previous changes() function returns 1 no matter what
  • Modified changes() and total_changes() to be closer to the sqlite implementation
    • Store local n_change counter in the Program struct
    • Update last_change and total_changes values in Connection struct on halt
    • Add change_cnt_on flag to Program struct that is true for insert and delete (also need later on for update)
  • Added TCL tests

@penberg penberg changed the title improved changes() and total_changes() and added tests Improve changes() and total_changes() functions and add tests Jan 20, 2025
@penberg penberg closed this in 11551e8 Jan 20, 2025
@penberg penberg merged commit 11551e8 into tursodatabase:main Jan 20, 2025
37 checks passed
@ben594 ben594 deleted the fix-bug-in-changes-scalarfunc branch January 20, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants