Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement button path in custom_parameter #566

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Conversation

twonirwana
Copy link
Owner

make it possible to configure different button paths

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 94.02174% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (e184f76) to head (5dd380a).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ommand/customParameter/CustomParameterCommand.java 88.23% 0 Missing and 8 partials ⚠️
...mand/customParameter/CustomParameterValidator.java 97.16% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #566      +/-   ##
============================================
+ Coverage     69.59%   70.01%   +0.41%     
- Complexity     1144     1169      +25     
============================================
  Files           104      105       +1     
  Lines          5387     5429      +42     
  Branches        552      558       +6     
============================================
+ Hits           3749     3801      +52     
+ Misses         1221     1211      -10     
  Partials        417      417              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	bot/src/main/java/de/janno/discord/bot/command/customParameter/CustomParameterCommand.java
#	bot/src/test/java/de/janno/discord/bot/command/customDice/CustomDiceCommandMockTest.snap
#	bot/src/test/java/de/janno/discord/bot/command/customParameter/CustomParameterCommandMockTest.snap
#	bot/src/test/java/de/janno/discord/bot/command/help/QuickstartCommandMockTest.snap
#	bot/src/test/java/de/janno/discord/bot/command/help/WelcomeCommandMockTest.snap
#	bot/src/test/java/de/janno/discord/bot/command/reroll/RerollAnswerHandlerMockTest.snap
#	bot/src/test/java/de/janno/discord/bot/command/sumCustomSet/SumCustomSetCommandMockTest.snap
#	gradle/wrapper/gradle-wrapper.properties
@twonirwana twonirwana merged commit 758f744 into main Nov 4, 2024
6 checks passed
@twonirwana twonirwana deleted the customparameterPath branch November 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant