Add methods arity and foldLeft0 #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure foldLeft0 is the perfect or desired interface. But I am opening this PR to show that (at least to my understanding) a TypeClass like ShowType can not be implemented in the current interface. Of course one can argue that the traversal in ShowType should be done at compile time since it does not depend on any runtime types. But I have a use case where I want to have a type class that need to traverse the elements in multiple ways and being able to implement all of them using the shapeless 3 API would be useful.
|
I can see the reasoning, why not. I thought internals are ignored by MiMa, need to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure foldLeft0 is the perfect or desired interface. But I am opening this PR to show that (at least to my understanding) a TypeClass like ShowType can not be implemented in the current interface.
Of course one can argue that the traversal in ShowType should be done at compile time since it does not depend on any runtime values. But I have a use case where I want to have a type class that need to traverse the elements in multiple ways and being able to implement all of them using the shapeless 3 API would be useful.