This repository has been archived by the owner on May 4, 2022. It is now read-only.
ci: remove greenkeeper lockfile upload step #722
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GreenKeeper lockfile upload step, requires having a secure token injected into the public continuous integration environment.
With the current GitHub oauth API, this would mean the generating user would need to create a token, that gives write access to ALL of their public GitHub repositories.
This might be feasible with a build user scoped to a single repository, or if GitHub improves their API.
However at the moment this seems like a security risk.
Short term the best solution appears to be disabling the upload step, so CI doesn't waste time attempting a push that will not work.
Leaving humans to manually
rm -rf package-lock.json node_modules && npm install && git commit -a -m "chore(package): update package lock file" && git push upstream
Contributor License Agreement adherence: