Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tick labels that are outside the selected date interval #1960

Open
wants to merge 4 commits into
base: xdmod11.0
Choose a base branch
from

Conversation

aestoltm
Copy link
Contributor

Description

The previous fix to address timeseries tick labels outside of the date range was in PR #1899, however, it was found that using 'category' axis type can cause timeseries plots to display data out of order if the series have varying date intervals.

This fix is for "Day" aggregation unit. The other units are handled by using a "linear" tickmode from PR #1899

This refactor puts the work on Plotly to correctly order the axis by using the "date" axis type. To address the original issue of having date tick labels outside the date interval I decided to follow @jpwhite4 suggestions to remove tick labels that are outside the selected duration.

Plotly relayout events are tied to the Ext.js 'resize' event, but Plotly relayout events can happen outside of Ext.js 'resize' events (e.g. Zoom is a relayout event but not resize), therefore, I needed to add a listener to the Usage tab to ensure erroneous tick labels were removed on zooming (mainly resetting the zoom). The metric explorer tab already had a listener on the relayout event.

Motivation and Context

Out of order timeseries plots are very undesirable. Makes it impossible to accurately view the plot

Tests performed

Tested on my dev-port on xdmod-dev

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@aestoltm aestoltm added bug Bugfixes Category:Metric Explorer Metric Explorer / Usage Category:User Dashboard Screen shown after user login labels Dec 19, 2024
@aestoltm aestoltm added this to the 11.0.1 milestone Dec 19, 2024
@aestoltm aestoltm self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:Metric Explorer Metric Explorer / Usage Category:User Dashboard Screen shown after user login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants