refac: DRY up New, reuse *All methods, delete modules slice #1258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern we appear to have for Fx operations (Provide, Invoke, etc.)
take the form:
This means that the following two are equivalent:
Except (2) is DRYer.
This cleans up New by relying on root-level
*All
methodsinstead of manually iterating over modules.
Making this change also highlighted that 'app.modules'
only ever has one entry: the root module.
So we can delete that field from App as well.
Finally, this also renames: