-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: proxy callbacks #9
refactor: proxy callbacks #9
Conversation
Unused types (1)
|
QA: ubq-testing#7 |
I'm unable to request review for some reason so gonna tag instead @gentlementlegen @0x4007 @sshivaditya2019 @sshivaditya @rndquu |
I've never got my own kernel/plugin set up so I don't have any context on this problem and can't add any value in the form of a review. |
It's the solution to this ubiquity-os/ubiquity-os-kernel#10 |
Good to merge? @sshivaditya2019 @gentlementlegen @whilefoo |
It's extremely redundant. This can all be expressed in a sentence or two. |
I don't understand what you are referring to QA demonstrates that the plugin is working that's all it has nothing to do with the content in the LLM response. This PR is about adding the proxy so we can handle multiple webhook event payloads. If you are referring to ground truths there a spec to improve them #17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see some code refactoring!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't hesitate to move that to the SDK, it makes things much simpler!
Yeah we definitely should build our webhook handler logic into the SDK I have a couple of tasks I'll close out first but I won't forget about it |
I can't merge if it's me we are waiting on for this fellas |
8ea7b0f
into
ubiquity-os-marketplace:development
Resolves #10
Required by ubiquity-os/plugins-wishlist#45
This PR adds the
proxyCallback
logic that we use in other plugins. I'm adding it because it's the cleanest most effective way to handle type-safe payloads across every webhook event and I need it for handlingpull_request
events.I've noticed a separate issue regarding
Logs
which is that sometimes we get stack traces, sometimes we don't which is not good.This should generate a stack but instead we get:
If we manually create an error in the metadata we get a stack trace but you can clearly see that
error
is an empty object which is wrong which is where my suspicion comes from that the logger is wiping out that property under certain conditions.Will open a task to get it addressed