Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure firefox (flatpak) has hardware decoding turned on by default #1876

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

tulilirockz
Copy link
Collaborator

Got this straight from Bazzite, just renamed a few thingies to make it Bluefin-themed :p - Fixes #1730

@tulilirockz tulilirockz requested a review from castrojo as a code owner November 4, 2024 02:34
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Nov 4, 2024
@bsherman
Copy link
Contributor

bsherman commented Nov 5, 2024

I'm not sure about all these settings... I don't think they are required to enable hardware accelerated video decoding.

I don't have any of them and hw accel decode works well for me. (I happen to have been testing this topic lately).

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go with this if it's only the 01-bluefin-global.js for now.

I've been testing hardware acceleration a lot this past week. So while I do want us to default enable media.ffmpeg.vaapi.enabled and gfx.webrender.all is also probably fine, I'm hesitant on the other changes just yet.

@tulilirockz tulilirockz force-pushed the firefox-hw-accelerated branch from 2798380 to 99c7971 Compare November 7, 2024 18:45
@tulilirockz tulilirockz force-pushed the firefox-hw-accelerated branch from 99c7971 to 594c5a5 Compare November 7, 2024 18:50
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@bsherman bsherman enabled auto-merge November 7, 2024 19:39
@bsherman bsherman added this pull request to the merge queue Nov 7, 2024
Merged via the queue into ublue-os:main with commit 59770f8 Nov 7, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure firefox has hardware decoding turned on
2 participants