Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Consolidate workflow into just commands #1910

Merged
merged 110 commits into from
Nov 10, 2024
Merged

chore(ci): Consolidate workflow into just commands #1910

merged 110 commits into from
Nov 10, 2024

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Nov 8, 2024

No description provided.

m2Giles added 30 commits November 1, 2024 13:15
@m2Giles
refactor: Reorganize Build Process
c6ae372 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>

This significantly reworks the build system for Bluefin/Aurora.

Changes:
Consolidates Workflows
Removes Surface and Asus images in favor of a single HWE image
Refwrite of local dev Justfile
Reorganization and Consolidation of build files

Add new files

Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
Merge branch 'main' into refactor-build
ad9b9cb
@m2Giles
fix: use raw-img for rechunk
258d1cb
@m2Giles
chore(ci): compat with old names
081dbba 
Keep the asus/surface images around until a service unit is written to rebase people onto hwe name images.
@m2Giles
try matrix in workflow call
637f641 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
Revert "try matrix in workflow call"
a06e9a1 
This reverts commit 637f641.
@m2Giles
try matrix changes again
5a6dcff 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
Revert "try matrix changes again"
f3ccdf7 
This reverts commit 5a6dcff.
@m2Giles
use inputs!
18fc0b0 
fixup
@m2Giles
Revert "use inputs!"
3c3daf1 
This reverts commit 18fc0b0.
@m2Giles
another matrix try
d50912b
@m2Giles
use include instead of exclude
b4ae212
@m2Giles
JSON String for matrix
927f8e9
@m2Giles
swap quotes
cfaa180
@m2Giles
fromJSON?
3e521b0
@m2Giles
remove quotes
53d3719
@m2Giles
another try?
d4522ad
@m2Giles
Single Line
01a24e1
@m2Giles
add selectable build choice
eeb845d
@m2Giles
push old hwe image names
b05c715
@m2Giles
handle defaults
757df34
@m2Giles
fix expression
0f69dc5
@m2Giles
Update build-image-latest.yml
5ba2948
@m2Giles
Update reusable-build.yml
0f84169
@m2Giles
Update build-image-latest.yml
8c7362e
@m2Giles
match for ISOs, loop tags
4251ec2
@m2Giles
add another build-fix
72a598e
@m2Giles
fix check for build-fix
52c2732
@m2Giles
ZFS verify based on akmods flavor
9e14a3b
@m2Giles
don't fail fast
cf2fe9c
@tulilirockz tulilirockz mentioned this pull request Nov 10, 2024
Closed
@m2Giles m2Giles marked this pull request as ready for review November 10, 2024 06:44
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 10, 2024
@m2Giles
Copy link
Member Author

m2Giles commented Nov 10, 2024

This is now ready for review

@m2Giles
Copy link
Member Author

m2Giles commented Nov 10, 2024

Reran checks. Found one more scheduled instead of schedule.

Made sure it runs locally again.

bsherman
bsherman approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't know for sure if its perfect until we merge due to some last stage only on non-PR steps, but we have caught a few and in general this is looking great!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@bsherman bsherman enabled auto-merge November 10, 2024 22:46
@bsherman bsherman disabled auto-merge November 10, 2024 22:52
@bsherman bsherman added this pull request to the merge queue Nov 10, 2024
Merged via the queue into main with commit e1d7cf1 Nov 10, 2024
53 of 54 checks passed
@bsherman bsherman deleted the justfile-workflow branch November 10, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@befanyt befanyt befanyt left review comments

@bsherman bsherman bsherman approved these changes

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
dx Developer Experience Image specific github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m2Giles @bsherman @befanyt @castrojo