Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass repo_organization to build script to ensure correct image metadata #2016

Merged

Conversation

cr7pt0gr4ph7
Copy link
Contributor

@cr7pt0gr4ph7 cr7pt0gr4ph7 commented Dec 6, 2024

This restores the old behavior (pre-#1867) of storing the GitHub repository owner of the repository used to build the image in image-info.json, instead of always using ublue-os. This is relevant for people (like me) building their own forks of this repository.

Also, clean up unnecessary trailing whitespaces in the affected files as well.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Dec 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2024
@castrojo castrojo added this pull request to the merge queue Dec 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2024
@cr7pt0gr4ph7
Copy link
Contributor Author

cr7pt0gr4ph7 commented Dec 9, 2024

Thanks for taking the time to review!

The failed merge seems to be due to a transient build failure due to unrelated updates in a package repository, and not related to this PR. Can you attempt to merge again?

@castrojo castrojo added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@castrojo castrojo added this pull request to the merge queue Dec 9, 2024
Merged via the queue into ublue-os:main with commit 84af7f2 Dec 9, 2024
42 checks passed
@cr7pt0gr4ph7 cr7pt0gr4ph7 deleted the pass-repo-organization-to-build branch December 9, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants