fix(just): fix configure-vfio recipe #2140
Merged
+24
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This was referenced Jan 11, 2025
castrojo
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2121.
This recipe is pulled straight from Bazzite. In Bazzite, users first call Bazzite's setup-virtualization recipe, which sets up the
kvm.report_ignored_msrkarg. In Bluefin/Aurora, we have the-dxvariant for virtualization which does not set this karg.To fix the recipe, we just need to remove the guard for the
kvm.report_ignored_msrkarg and just append it to the end.I confirmed that this works in a VM.