Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacthub): remove artifacthub category #2151

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

castrojo
Copy link
Member

This category doesn't exist, we need to remove it or it fails to ingest in ah.

This category doesn't exist, we need to remove it or it fails to ingest in ah.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@castrojo castrojo enabled auto-merge January 23, 2025 15:53
@castrojo
Copy link
Member Author

I don't understand how I broke the just file by removing these 2 lines?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@ledif
Copy link
Contributor

ledif commented Jan 23, 2025

The just check has been wonky lately. It doesn't help that there's a mismatch of versions between what is shipped in the images and what we use to validate our justfiles in the GH actions.

@castrojo
Copy link
Member Author

I'm assuming there's version skew between just in fedora and just-the-action?

@ledif
Copy link
Contributor

ledif commented Jan 23, 2025

Try pulling in the changes to Justfile here: https://github.com/ublue-os/aurora/pull/144/files.

@m2Giles
Copy link
Member

m2Giles commented Jan 23, 2025

You didn't. The formatter is slightly different on the newest version of just (which is used during the action) compared to what we have from fedora repos.

@castrojo castrojo added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit ccce3d5 Jan 24, 2025
35 checks passed
@castrojo castrojo deleted the castrojo-patch-3 branch January 24, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants