-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix spelling checks in auto-generated material #1069
Conversation
fbe5a1c
to
a2eda67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 79 79
Lines 6881 6881
=======================================
Hits 6455 6455
Misses 416 416
Partials 10 10 ☔ View full report in Codecov by Sentry. |
4f75243
to
a2eda67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small nitpick/question on the formatting.
a2eda67
to
9b14482
Compare
Added warning about contributing to reference docs. Update some links.
For maintenance, it is better not selectively include some files in the spellcheck.
9b14482
to
ea296b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
The reference section in the docs mostly consists of auto-generated material.
Some of the material is not under our control (dconf) as it comes from upstream packages.
As the main docs use GB spelling and the upstream US spelling, the latter fail our spellcheck.
We should use GB spelling where possible to be consistent with the rest of our docs and to prevent unnecessary context-switching when working on the docs. We cannot change some of the reference material; doing so could introduce inconsistencies with upstream and negatively affect the searchability of the docs.
This PR removes reference material relating to key type dconf from our automated spellcheck.
It also adds a warning to the CONTRIBUTING.md about the autogenerated docs, for future contributors who may wish to edit the files, along with some other minor fixes.
UDENG-3685
UDENG-3686
UDENG-3687