Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling checks in auto-generated material #1069

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

edibotopic
Copy link
Contributor

@edibotopic edibotopic commented Aug 14, 2024

The reference section in the docs mostly consists of auto-generated material.
Some of the material is not under our control (dconf) as it comes from upstream packages.
As the main docs use GB spelling and the upstream US spelling, the latter fail our spellcheck.

We should use GB spelling where possible to be consistent with the rest of our docs and to prevent unnecessary context-switching when working on the docs. We cannot change some of the reference material; doing so could introduce inconsistencies with upstream and negatively affect the searchability of the docs.

This PR removes reference material relating to key type dconf from our automated spellcheck.
It also adds a warning to the CONTRIBUTING.md about the autogenerated docs, for future contributors who may wish to edit the files, along with some other minor fixes.

UDENG-3685
UDENG-3686
UDENG-3687

@edibotopic edibotopic marked this pull request as ready for review August 14, 2024 09:54
@edibotopic edibotopic requested a review from a team as a code owner August 14, 2024 09:54
@edibotopic edibotopic marked this pull request as draft August 14, 2024 10:08
@edibotopic edibotopic force-pushed the docs-fix-automation-spelling branch from fbe5a1c to a2eda67 Compare August 14, 2024 10:10
@edibotopic edibotopic removed the request for review from a team August 14, 2024 10:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (2f9beeb) to head (ea296b8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files          79       79           
  Lines        6881     6881           
=======================================
  Hits         6455     6455           
  Misses        416      416           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edibotopic edibotopic force-pushed the docs-fix-automation-spelling branch from 4f75243 to a2eda67 Compare August 14, 2024 10:27
@edibotopic edibotopic marked this pull request as ready for review August 14, 2024 10:35
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small nitpick/question on the formatting.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@edibotopic edibotopic force-pushed the docs-fix-automation-spelling branch from a2eda67 to 9b14482 Compare August 19, 2024 09:50
Added warning about contributing to reference docs. Update some links.
For maintenance, it is better not selectively include some files in the spellcheck.
@edibotopic edibotopic force-pushed the docs-fix-automation-spelling branch from 9b14482 to ea296b8 Compare August 19, 2024 09:59
@edibotopic edibotopic requested a review from jibel August 19, 2024 10:06
Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@edibotopic edibotopic merged commit 9c78134 into main Aug 19, 2024
5 checks passed
@edibotopic edibotopic deleted the docs-fix-automation-spelling branch August 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants