Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(e2e): Return 0.0.0 as latest image version if none #829

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

GabrielNagy
Copy link
Contributor

Consumers of this method expect a X.Y.Z-style version to be returned. For the sake of simplicity we can treat "0.0.0" as the base/null version when no other versions exist.

Fixes https://github.com/ubuntu/adsys/actions/runs/6680473941/job/18153640853

Consumers of this method expect a X.Y.Z-style version to be returned.
For the sake of simplicity we can treat "0.0.0" as the base/null version
when no other versions exist.

Fixes https://github.com/ubuntu/adsys/actions/runs/6680473941/job/18153640853
@GabrielNagy GabrielNagy requested a review from a team as a code owner October 30, 2023 11:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #829 (a42f08e) into main (b41372b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files          76       76           
  Lines        8599     8599           
=======================================
  Hits         7404     7404           
  Misses        866      866           
  Partials      329      329           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GabrielNagy GabrielNagy merged commit 6e6f454 into main Oct 30, 2023
6 checks passed
@GabrielNagy GabrielNagy deleted the fix-latest-image-version branch October 30, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants