Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 556: Designate ActionLifecycle a subclass of ActionPattern #578

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Issue 556: Designate ActionLifecycle a subclass of ActionPattern #578

merged 1 commit into from
Jan 30, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Jan 22, 2024 •
edited
Loading

This Pull Request implements a bug-fix change proposal, believed to be of low risk to the ontology and its downstream resources. It resolves all requirements of Issue #556 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (c076115 )
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable as submodule (3f88c4c )
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status) (N/A)

@ajnelson-nist
Designate ActionLifecycle a subclass of ActionPattern
e017e87 
No effects were observed on Make-managed files.

References:
* #556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Jan 22, 2024
@ajnelson-nist ajnelson-nist linked an issue Jan 22, 2024 that may be closed by this pull request
Possible bug - ActionLifecycle is not a subclass of ActionPattern #556
Closed
7 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Jan 22, 2024
Closed
7 tasks
@ajnelson-nist ajnelson-nist marked this pull request as ready for review January 23, 2024 13:27
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist requested a review from a team January 23, 2024 13:28
sbarnum
sbarnum approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@sbarnum sbarnum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the appropriate fix.

@sbarnum sbarnum merged commit 491c70d into develop-2.0.0 Jan 30, 2024
1 check passed
@ajnelson-nist ajnelson-nist deleted the BugFix-Issue-556 branch January 31, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbarnum sbarnum sbarnum approved these changes

Assignees
No one assigned
Labels
bug Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

Possible bug - ActionLifecycle is not a subclass of ActionPattern
2 participants
@ajnelson-nist @sbarnum