add temporary wasm buffer to instance

ucpu · Jan 19, 2025 · f175b37 · f175b37
1 parent 05b3f76
commit f175b37
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/sources/include/cage-core/wasm.h b/sources/include/cage-core/wasm.h
@@ -232,8 +232,6 @@ namespace cage
 	{
 	public:
 		WasmFunction() = default;
-		//WasmFunction(WasmFunction &&) = default;
-		//WasmFunction &operator=(WasmFunction &&) = default;
 
 		explicit WasmFunction(Holder<privat::WasmFunctionInternal> &&func_) : func(std::move(func_))
 		{
@@ -305,6 +303,8 @@ namespace cage
 			return WasmFunction<T>(function_(name));
 		}
 
+		WasmBuffer temporary; // use for passing data in function calls
+
 	private:
 		Holder<privat::WasmFunctionInternal> function_(const WasmName &name);
 	};

diff --git a/sources/libcore/wasm.cpp b/sources/libcore/wasm.cpp
@@ -193,7 +193,7 @@ namespace cage
 				if (!instance)
 				{
 					err.rawLength() = std::strlen(err.rawData());
-					CAGE_LOG_CONTINUE(SeverityEnum::Note, "wasm", err);
+					CAGE_LOG_THROW(err);
 					CAGE_THROW_ERROR(Exception, "failed instantiating wasm module");
 				}
 				exec = wasm_runtime_get_exec_env_singleton(instance);
@@ -204,6 +204,7 @@ namespace cage
 
 			~WasmInstanceImpl()
 			{
+				temporary = {};
 				if (instance)
 				{
 					wasm_runtime_deinstantiate(instance);