Skip to content

Commit

Permalink
fix: clone over https (#134)
Browse files Browse the repository at this point in the history
Fix: use `https` to clone `ffmpeg` repo

Description:

Current `.sh` script uses `ssh` to `git clone` repo for `ffmpeg`.

However, many people (like me) building may be using a build environment without GitHub ssh setup. Attempting to clone GitHub repo without ssh keys setup results in the following error:

```bash
Cloning into 'ffmpeg'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
```
  • Loading branch information
jarrodcolburn authored Dec 4, 2023
1 parent 7c5ad70 commit 4c883b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libs/compositor-ffmpeg-h264/build_wasm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ popd

FFMPEG_VERSION="n5.1.2"
ensure_ffmpeg() {
[ -e ffmpeg ] || git clone --depth 1 --branch "$FFMPEG_VERSION" "git@github.com:FFmpeg/FFmpeg.git" ffmpeg
[ -e ffmpeg ] || git clone --depth 1 --branch "$FFMPEG_VERSION" "https://github.com/FFmpeg/FFmpeg.git" ffmpeg
}

build() {
Expand Down

0 comments on commit 4c883b5

Please sign in to comment.