Updates to C3 and SAS convection schemes #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisa-bengtsson
requested review from
JongilHan66,
grantfirl,
Qingfu-Liu,
dustinswales and
haiqinli
as code owners
This was referenced Oct 25, 2023
dustinswales
requested changes
Oct 26, 2023
move setting of flag from run to init phase
Qingfu-Liu
approved these changes
Nov 2, 2023
JongilHan66
approved these changes
Nov 2, 2023
haiqinli
approved these changes
Nov 2, 2023
dustinswales
approved these changes
Nov 2, 2023
This was referenced Nov 8, 2023
|
Testing for #1941 has completed successfully, please continue with the merge process. |
Copying @lisa-bengtsson and @grantfirl as well. Please feel free to merge this PR. |
grantfirl
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Brings out tuning parameters from the progsigma_calc.F90, which are used in the saSAS and C3 shallow and deep cumulus convection schemes.
*Adds a limiter on area fraction to not exceed 0.95 after final tuning
*Updates the regression test used for gfsv17 tests, to include extracted parameters in the namelist.
For RRFSv1 ensemble members using saSAS convection, workflow updates are needed.
Some justification for the PR can be found here: https://docs.google.com/presentation/d/11WVCFAb-JM628N2RyAWLqjxxrSovKU8AB72xBZJ1FfI/edit#slide=id.p
Addresses issue: ufs-community/ufs-weather-model#1964