-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for ufs-coastal app; update MOM6 to its main repo. 20250113 commit (original 20241127-PR) (was #2556) #2396
Modifications for ufs-coastal app; update MOM6 to its main repo. 20250113 commit (original 20241127-PR) (was #2556) #2396
Conversation
* the wave restarts are not b4b against the develop baseline but are b4b when compared against a baseline generated with the trho fix rt_atmwav_control_noaero_p8_intel.log: Comparing ufs.atmw.ww3.r.2021-03-22-64800 .....USING CMP......NOT IDENTICAL rt_hafs_regional_atm_wav_intel.log: Comparing ufs.hafs.ww3.r.2019-08-29-21600 .....USING CMP......NOT IDENTICAL
@DeniseWorthen Do you think that we need to find more meaningful aliases for the new fields defined in the dictionary. We could try to come up a set of standard names for them but not sure. Let me know what you think? |
@uturuncoglu I'm not sure how useful the aliases are if we have the description. So, for example we could make an alias for I do see now I should have probably named some of the new fields with "Fw" (as fluxes) and not "Sw" as states. |
@DeniseWorthen Yes, SCHSIM follows convention like that. See following part, https://github.com/oceanmodeling/schism-esmf/blob/12e2ce43475fe85212c60de7894524d22a1bab96/src/schism/schism_nuopc_cap.F90#L414. It is not big deal and I am using short names at this point for the implementation but we might consider to add aliases and use them in the SCHSIM side. anyway, I'll let you know when PR is ready in ufs coastal side. So, you could check it. |
I see, thanks. We definitely might need aliases then. |
@DeniseWorthen @JessicaMeixner-NOAA @janahaddad We had a meeting with costal team today. Here is our proposal,
Anyway, let me know what do you think about this plan. We are open any other suggestion at this point. |
@uturuncoglu I do think it is a good idea for Coastal to test the changes in the WW3 cap as much as possible while we wait for the stoppage of PRs in WW3 to lift. Also keep in mind that once the stoppage lifts, PRs to dev/ufs-weather-model will most likely be further delayed as community development (going to the develop branch) will also need to proceed. Also, I wanted to make Coastal aware of Issue NOAA-EMC/WW3#1298 in case you haven't seen it. |
@DeniseWorthen That is great. BTW, Thanks for pointing the PIO PR. |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@DeniseWorthen can you modify the PR tilte and add "update MOM6 to its main repo. 20250113 commit (20241127-PR)" ? |
@jiandewang I also added a commit message line for MOM6 |
@DeniseWorthen Thanks |
@BrianCurtis-NOAA do you want to go for merging this pr if we skip Acorn ? |
We can start merging process. |
kust merged MOM6 with hash # 6fff095 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logs on Hercules weren't found for hrrr_control_2threads_gnu but test did pass. (More of an FYI / record keeping in case this keeps happening)
Rocoto/Hercules is not that robust: a few cases are randomly dropped. But if jobs are resubmitted, all is ok. |
Commit Queue Requirements:
Description:
Updates WW3 for modifications and fixes required by UFS-Coastal App
Updates MOM6 for main repo
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
None
Input data Changes:
Library Changes/Upgrades:
Testing Log: