Merge pull request #7420 from uktrade/fix/omis-order-quote-accepted-by

Render OMIS order quote `accepted_by` only if defined
uktrade · Dec 20, 2024 · 6d45f0e · 6d45f0e
2 parents 6e0e245 + 783eb59
commit 6d45f0e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/client/modules/Omis/OrderQuote.jsx b/src/client/modules/Omis/OrderQuote.jsx
@@ -128,7 +128,9 @@ const AcceptedOn = ({ quote }) => (
       {formatDate(quote.acceptedOn, DATE_FORMAT_MEDIUM_WITH_TIME)}
     </StyledP>
     <StyledHeading data-test="accepted-by-heading">Accepted by</StyledHeading>
-    <StyledP data-test="accepted-by-name">{quote.acceptedBy.name}</StyledP>
+    {quote.acceptedBy && (
+      <StyledP data-test="accepted-by-name">{quote.acceptedBy.name}</StyledP>
+    )}
   </>
 )
 

diff --git a/test/functional/cypress/specs/omis/quote-spec.js b/test/functional/cypress/specs/omis/quote-spec.js
@@ -214,6 +214,13 @@ describe('Order quote', () => {
     })
   })
 
+  context('When the quote has been accepted, but accepted_by is null', () => {
+    it('should not render accepted-by-name', () => {
+      cy.visit(urls.omis.quote(quoteAccepted.id))
+      cy.get('[data-test="accepted-by-name"]').should('not.exist')
+    })
+  })
+
   context('When the order has been cancelled', () => {
     beforeEach(() => {
       cy.visit(urls.omis.quote(cancelledOrder.id))