Merge pull request #7412 from uktrade/bump_history

TET-758: Only replace history if params has values
uktrade · Dec 23, 2024 · f77b4d1 · f77b4d1
2 parents 3170151 + 9991168
commit f77b4d1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 29 deletions.
diff --git a/assets/javascripts/lib/xhr.js b/assets/javascripts/lib/xhr.js
@@ -39,7 +39,7 @@ const XHR = {
   updateOutlet(res, params, win = window) {
     this.injectResponseInHtml(res.data)
 
-    if (params) {
+    if (params && Object.keys(params).length > 0) {
       const url = `?${queryString.stringify(params)}`
       try {
         history.replace(url, { data: res.data })

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -101,7 +101,7 @@
     "govuk-frontend": "^5.7.1",
     "govuk-react": "^0.10.7",
     "hawk": "^9.0.2",
-    "history": "^4.10.1",
+    "history": "^5.3.0",
     "http-proxy-middleware": "^3.0.0",
     "joi": "^17.13.1",
     "lodash": "^4.17.21",
@@ -225,4 +225,4 @@
     "semver": "7.5.2",
     "tough-cookie": "4.1.3"
   }
-}
+}