Merge pull request #2833 from uktrade/fix/dit-dbt-migration-fix

fixing eligibility_criteria changes
uktrade · Nov 2, 2023 · c1bff03 · c1bff03
2 parents b867ab9 + ef32342
commit c1bff03
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/dataworkspace/dataworkspace/apps/datasets/migrations/0155_catalogues_replace_dit_dbt.py b/dataworkspace/dataworkspace/apps/datasets/migrations/0155_catalogues_replace_dit_dbt.py
@@ -67,19 +67,20 @@ def search_and_replace_specific_fields(model):
     )
     for dataset in model.objects.exclude(name__in=skip_items).all():
         if dataset.eligibility_criteria:
-            eligibility_criteria = list(dataset.eligibility_criteria)
             eligibility_criteria = [
                 re.sub(criteria, dit, dbt, flags=re.IGNORECASE)
-                for criteria in eligibility_criteria
+                for criteria in list(dataset.eligibility_criteria)
             ]
+            dataset.eligibility_criteria = eligibility_criteria
+            dataset.save()
             eligibility_criteria = [
                 re.sub(
                     criteria,
                     dit_full,
                     dbt_full,
                     flags=re.IGNORECASE,
                 )
-                for criteria in eligibility_criteria
+                for criteria in list(dataset.eligibility_criteria)
             ]
             dataset.eligibility_criteria = eligibility_criteria
             dataset.save()