Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTR-514 Add network type field #857

Merged
merged 5 commits into from
Jan 21, 2025
Merged

INTR-514 Add network type field #857

merged 5 commits into from
Jan 21, 2025

Conversation

CamLamb
Copy link
Contributor

@CamLamb CamLamb commented Jan 10, 2025

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

Need to agree list of network types before merging this PR

@CamLamb
Copy link
Contributor Author

CamLamb commented Jan 17, 2025

TODO: Add a flag to hide this from the Wagtail Admin until we have an agreed list of Network Types

@CamLamb CamLamb marked this pull request as ready for review January 20, 2025 12:17
@CamLamb CamLamb requested a review from a team as a code owner January 20, 2025 12:17
@CamLamb CamLamb requested a review from smanga24 January 20, 2025 12:17
@CamLamb CamLamb added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit c140775 Jan 21, 2025
4 checks passed
@CamLamb CamLamb deleted the INTR-514 branch January 21, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopicchio nicopicchio nicopicchio approved these changes

@smanga24 smanga24 Awaiting requested review from smanga24 smanga24 is a code owner automatically assigned from uktrade/boomslangs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CamLamb @nicopicchio