Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DBTP-1629 decoupling with duck typing #713

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

a-gleeson
Copy link
Contributor

@a-gleeson a-gleeson commented Jan 9, 2025

Addresses DBTP-1629

Diagram

image

Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

  • Run the end to end tests for this branch and confirm that they are passing

@a-gleeson a-gleeson requested a review from a team as a code owner January 9, 2025 14:13
@a-gleeson a-gleeson changed the title refactor: DBTP 1629 decoupling with duck typing refactor: DBTP-1629 decoupling with duck typing Jan 9, 2025
@codecov-commenter
Copy link

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
652 1 651 3
View the top 1 failed tests by shortest run time
tests/platform_helper/domain/test_get_supported_aws_versions.py::tests.platform_helper.domain.test_get_supported_aws_versions
Stack Traces | 0s run time
.../platform_helper/domain/test_get_supported_aws_versions.py:3: in <module>
    from dbt_platform_helper.domain.versions import get_supported_aws_versions
dbt_platform_helper/domain/versions.py:10: in <module>
    GetReferenceProtocol | GetVersionsProtocol
E   TypeError: unsupported operand type(s) for |: '_ProtocolMeta' and '_ProtocolMeta'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants