Bugfix: Added forgotten render call on error block in command router

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.0.3 - 2020-05-02
+### Fixed
+- Forgotten render call on error block.
+
 ## 1.0.2 - 2020-04-09
 ### Changed
 - Changed packages to GrizzIT variations.
@@ -17,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Created the initial implementation of the command package.
 
 # Versions
-- [1.0.2 > Unreleased](https://github.com/ulrack/command/compare/1.0.1...HEAD)
+- [1.0.3 > Unreleased](https://github.com/ulrack/command/compare/1.0.3...HEAD)
+- [1.0.2 > 1.0.3](https://github.com/ulrack/command/compare/1.0.2...1.0.3)
 - [1.0.1 > 1.0.2](https://github.com/ulrack/command/compare/1.0.1...1.0.2)
 - [1.0.0 > 1.0.1](https://github.com/ulrack/command/compare/1.0.0...1.0.1)

phpcs.xml

@@ -8,6 +8,5 @@
     <arg name="colors" />
     <arg value="s" />
 
-    <!-- Use the PSR2 Standard-->
-    <rule ref="PSR2" />
+    <rule ref="PSR12" />
 </ruleset>

src/Command/HelpCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Command/ListCommandsCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Common/Command/CommandInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Common/Command/InputInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Common/Command/OutputInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Common/Dao/CommandConfigurationInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Common/Factory/InputFactoryInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Common/Router/RouterInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Component/Command/Input.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.
@@ -83,13 +84,17 @@ public function hasParameter(string $parameter): bool
         }
 
         if ($this->commandConfiguration !== null) {
-            foreach ($this->commandConfiguration
-            ->getParameters() as $parameterInput) {
+            foreach (
+                $this->commandConfiguration
+                ->getParameters() as $parameterInput
+            ) {
                 $long = $parameterInput['long'] ?? '';
                 $short = $parameterInput['short'] ?? '';
                 if ($long === $parameter || $short === $parameter) {
-                    if (array_key_exists($long, $this->parameters)
-                    || array_key_exists($short, $this->parameters)) {
+                    if (
+                        array_key_exists($long, $this->parameters)
+                        || array_key_exists($short, $this->parameters)
+                    ) {
                         return true;
                     }
                 }
@@ -157,10 +162,14 @@ public function isSetFlag(string $flag): bool
 
         if ($this->commandConfiguration !== null) {
             foreach ($this->commandConfiguration->getFlags() as $configFlag) {
-                if ($configFlag['long'] === $flag
-                || $configFlag['short'] === $flag) {
-                    if (in_array($configFlag['long'], $this->flags)
-                    || in_array($configFlag['short'], $this->flags)) {
+                if (
+                    $configFlag['long'] === $flag
+                    || $configFlag['short'] === $flag
+                ) {
+                    if (
+                        in_array($configFlag['long'], $this->flags)
+                        || in_array($configFlag['short'], $this->flags)
+                    ) {
                         return true;
                     }
                 }

src/Component/Command/Output.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Component/Router/CommandRouter.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.
@@ -121,10 +122,12 @@ public function __invoke(InputInterface $input): int
 
             if ($serviceKey !== '') {
                 try {
-                    foreach ($this->getMissingParameters(
-                        $input,
-                        $command
-                    ) as $key => $value) {
+                    foreach (
+                        $this->getMissingParameters(
+                            $input,
+                            $command
+                        ) as $key => $value
+                    ) {
                         $input->setParameter($key, $value);
                     }
                 } catch (MisconfiguredCommandException $exception) {
@@ -159,7 +162,7 @@ public function __invoke(InputInterface $input): int
             $this->errorElementFactory->createBlock(
                 $exception->getMessage(),
                 'error-block'
-            );
+            )->render();
 
             $code = $exception->getCode();
 
@@ -210,24 +213,32 @@ private function getMissingParameters(
         $missing = false;
         $this->formGenerator->init(
             'Missing parameters',
-            'The following parameters were required and missing. '.
+            'The following parameters were required and missing. ' .
             'Please fill them in before execution procceeds.'
         );
 
         foreach ($configuration->getParameters() as $parameter) {
-            if (isset($parameter['required'])
-            && $parameter['required']) {
-                if (!$input->hasParameter(
-                    $parameter['long'] ?? $parameter['short']
-                )) {
+            if (
+                isset($parameter['required'])
+                && $parameter['required']
+            ) {
+                if (
+                    !$input->hasParameter(
+                        $parameter['long'] ?? $parameter['short']
+                    )
+                ) {
                     $missing = true;
-                    if (isset($parameter['hidden'])
-                    && $parameter['hidden']) {
+                    if (
+                        isset($parameter['hidden'])
+                        && $parameter['hidden']
+                    ) {
                         $this->createHiddenField($parameter);
 
                         continue;
-                    } elseif (isset($parameter['options'])
-                    && is_array($parameter['options'])) {
+                    } elseif (
+                        isset($parameter['options'])
+                        && is_array($parameter['options'])
+                    ) {
                         $this->createAutocompletingField($parameter);
 
                         continue;

src/Dao/CommandConfiguration.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Exception/CommandCanNotExecuteException.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Exception/CommandNotFoundException.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Exception/MisconfiguredCommandException.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

src/Factory/InputFactory.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.
@@ -67,7 +68,8 @@ private static function prepareArguments(array $arguments): array
 
                 // No subsequent value starting without a "-"
                 // It must be a flag
-                if (empty($arguments[0])
+                if (
+                    empty($arguments[0])
                     || substr($arguments[0], 0, 1) === '-'
                 ) {
                     $flags[] = ltrim($argument, '-');

tests/Command/HelpCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

tests/Command/ListCommandsCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

tests/Component/Command/InputTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

tests/Component/Command/OutputTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

tests/Component/Router/CommandRouterTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

tests/Dao/CommandConfigurationTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.

tests/Factory/InputFactoryTest.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright (C) GrizzIT, Inc. All rights reserved.
  * See LICENSE for license details.