Fixed issue in base router where more output was generated after a 404

ulrack · Jan 17, 2021 · c38284c · c38284c
1 parent 439c9c3
commit c38284c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 3.0.1 - 2021-01-17
+
+### Fixed
+- Fixed issue where it was possible to get more output after a 404 was generated.
+
 ## 3.0.0 - 2021-01-17
 
 ### Added
@@ -37,7 +42,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - The initial implementation of the package.
 
 # Versions
-- [3.0.0 > Unreleased](https://github.com/ulrack/web/compare/3.0.0...HEAD)
+- [3.0.1 > Unreleased](https://github.com/ulrack/web/compare/3.0.0...HEAD)
+- [3.0.0 > 3.0.1](https://github.com/ulrack/web/compare/3.0.0...3.0.1)
 - [2.0.0 > 3.0.0](https://github.com/ulrack/web/compare/2.0.0...3.0.0)
 - [1.0.1 > 2.0.0](https://github.com/ulrack/web/compare/1.0.1...2.0.0)
 - [1.0.0 > 1.0.1](https://github.com/ulrack/web/compare/1.0.0...1.0.1)
diff --git a/src/Component/Router/BaseRouter.php b/src/Component/Router/BaseRouter.php
@@ -104,6 +104,8 @@ public function __invoke(
     ): void {
         if (!$this->found) {
             $this->errorHandler->outputByCode(404);
+
+            return;
         }
 
         try {
-Original file line number
+Diff line change
@@ Expand Up / @@ -104,6 +104,8 @@ public function __invoke( @@
         ): void {
             if (!$this->found) {
                 $this->errorHandler->outputByCode(404);
+                return;
             }
             try {
@@ Expand Down @@