Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated article and mentions of it #6737

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Conversation

eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Dec 11, 2024

Description

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

CMS v 14 and 15

Deadline (if relevant)

Anytime

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Remember redirects when you delete an article 💪

Might make sense to link to the Umbraco Flavoured Markdown here 🤔

@eshanrnh
Copy link
Contributor Author

Yup, I've added redirects to the Umbraco flavored markdown article.

@sofietoft
Copy link
Contributor

Great! When we make these kind of redirects, does it make sense to add some information to the article we're redirecting to?
To clear up any confusion that might occur if you're confused about seeing a different article that the one you where looking for? 🤔

@eshanrnh
Copy link
Contributor Author

That's a great point 🙌 It will definitely make sense to provide some context on the redirected article. I have added a Note in the article. Let me know what you think 😀

@eshanrnh
Copy link
Contributor Author

I've tweaked the Note slightly to mention why we are using UFM 😀Hope it's fine.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Super idea adding a bit more detail to the note 🙌

@eshanrnh eshanrnh merged commit 749fafa into main Dec 12, 2024
5 checks passed
@eshanrnh eshanrnh deleted the deprecated-article branch December 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants