Fix bug with routing key (#63)

* main

* spec

* Fix rubocop

* fix

* Version and Changelog

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [6.0.3] - 2021-12-09
+### Fixed
+Fixed bug when routing key is nil.
+
 ## [6.0.2] - 2021-12-01
 ### Fixed
 - Fixed bug: skip publish when object is new and event is destroy for ActiveRecord

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    table_sync (6.0.2)
+    table_sync (6.0.3)
       memery
       rabbit_messaging
       rails

lib/table_sync/publishing/message/batch.rb

@@ -7,7 +7,7 @@ class Batch < Base
 
     def params
       TableSync::Publishing::Params::Batch.new(
-        object_class: object_class, headers: headers, routing_key: routing_key,
+        attributes.slice(:object_class, :headers, :routing_key).compact,
       ).construct
     end
   end

lib/table_sync/publishing/message/raw.rb

@@ -47,7 +47,7 @@ def data
 
     def params
       TableSync::Publishing::Params::Raw.new(
-        object_class: object_class, routing_key: routing_key, headers: headers,
+        attributes.slice(:object_class, :headers, :routing_key).compact,
       ).construct
     end
   end

lib/table_sync/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TableSync
-  VERSION = "6.0.2"
+  VERSION = "6.0.3"
 end

spec/publishing/batch_spec.rb

@@ -9,7 +9,8 @@
   let(:event)	{ :update }
   let(:object_class)				  { "ARecordUser" }
   let(:routing_key)					  { object_class.tableize }
-  let(:headers)					      { { klass: object_class } }
+  let(:expected_routing_key) { "a_record_users" }
+  let(:headers) { { klass: object_class } }
 
   let(:attributes) do
     {
@@ -27,6 +28,16 @@
   context "real user" do
     context "sequel" do
       let(:object_class) { "SequelUser" }
+      let(:expected_routing_key) { "sequel_users" }
+
+      include_examples "publisher#publish_now with real user, for given orm",
+                       :sequel
+    end
+
+    context "when routing key is nil" do
+      let(:object_class) { "SequelUser" }
+      let(:routing_key) { nil }
+      let(:expected_routing_key) { "sequel_users" }
 
       include_examples "publisher#publish_now with real user, for given orm",
                        :sequel

spec/publishing/raw_spec.rb

@@ -4,6 +4,7 @@
   let(:object_class) { "SequelUser" }
   let(:event)               { :update }
   let(:routing_key)         { "custom_routing_key" }
+  let(:expected_routing_key) { "custom_routing_key" }
   let(:headers) { { some_key: "123" } }
   let(:original_attributes) { [{ id: 1, name: "purum" }] }
 
@@ -24,4 +25,12 @@
 
   include_examples "publisher#publish_now without stubbed message",
                    TableSync::Publishing::Message::Raw
+
+  context "when routing_key is nil" do
+    let(:routing_key) { nil }
+    let(:expected_routing_key) { "sequel_users" }
+
+    include_examples "publisher#publish_now without stubbed message",
+                     TableSync::Publishing::Message::Raw
+  end
 end

spec/publishing/single_spec.rb

@@ -8,6 +8,7 @@
   let(:event) { :update }
   let(:object_class)				{ "ARecordUser" }
   let(:routing_key)					{ object_class.tableize }
+  let(:expected_routing_key) { "a_record_users" }
   let(:headers) { { klass: object_class } }
   let(:debounce_time)	{ 30 }
 
@@ -27,6 +28,16 @@
     context "real user" do
       context "sequel" do
         let(:object_class) { "SequelUser" }
+        let(:expected_routing_key) { "sequel_users" }
+
+        include_examples "publisher#publish_now with real user, for given orm",
+                         :sequel
+      end
+
+      context "when routing key is nil" do
+        let(:object_class) { "SequelUser" }
+        let(:routing_key) { nil }
+        let(:expected_routing_key) { "sequel_users" }
 
         include_examples "publisher#publish_now with real user, for given orm",
                          :sequel

spec/support/shared/publishers.rb

@@ -40,7 +40,7 @@
             model: object_class,
             version: an_instance_of(Float),
           ),
-          routing_key: routing_key, # defined by callable by default
+          routing_key: expected_routing_key, # defined by callable by default
           headers: headers, # defined by callable by default
         )
       end