AVR support #2021

glennsec · 2024-10-02T13:31:52Z

Hi, this adds support for AVR (#939), while keeping XMEGA bits (with DES instruction) currently separate. This PR is rebased against the current dev branch, while original support was developed and more thoroughly tested against unicorn 2.0.x.

aquynh · 2024-10-03T01:24:56Z

samples/sample_avr.c

+            break;
+
+        // Initialize registers
+        uint8_t regs[32];


please move all the variable declaration to the beginning of the function

aquynh · 2024-10-03T01:28:01Z

Thanks for the contribution!

please update README to add this new architecture.
please add your name to CREDITS.TXT.

aquynh · 2024-10-03T01:38:38Z

can you look at the issues of the CI?

bet4it · 2024-10-03T13:29:23Z

You need to add Rust bindings manually😅

glennsec · 2024-10-09T21:10:07Z

Thanks for the contribution!

please update README to add this new architecture.

please add your name to CREDITS.TXT.

done

glennsec · 2024-10-09T21:11:17Z

can you look at the issues of the CI?

Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ?

wtdcode · 2024-10-10T11:08:24Z

can you look at the issues of the CI?

Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ?

There are also macos failures.

glennsec · 2024-10-11T19:26:08Z

can you look at the issues of the CI?

Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ?

There are also macos failures.

Hi, this is related to the tcg/aarch64 backend issue mentioned in #1908 with proposed fix in #1935. I have another patch suggestion that fixes the issue, as you can see in the last CI run at https://github.com/glennsec/unicorn/actions/runs/11298077207
(still, ppc64 needs similar treatment).

glennsec · 2024-10-11T19:31:01Z

See #2028. Feel free to integrate whichever (vs. #1935) suits you best. Thanks.

glennsec · 2024-10-22T13:07:23Z

See #2028. Feel free to integrate whichever (vs. #1935) suits you best. Thanks.

@wtdcode : I have updated the branch against #1935 (which applies on top of current dev branch) to include aarch64 & ppc64 fixes. Thanks.

wtdcode · 2024-10-22T13:08:28Z

See #2028. Feel free to integrate whichever (vs. #1935) suits you best. Thanks.

@wtdcode : I have updated the branch against #1935 (which applies on top of current dev branch) to include aarch64 & ppc64 fixes. Thanks.

I will have a check this week.

in7egral · 2024-11-11T09:26:33Z

I'm looking forward for this PR, as my idaemu fork will be redesigned soon, and I wish to add AVR as well.

@aquynh @wtdcode what's have to be done for merge?

wtdcode · 2024-11-11T13:08:22Z

I'm looking forward for this PR, as my idaemu fork will be redesigned soon, and I wish to add AVR as well.

@aquynh @wtdcode what's have to be done for merge?

Thanks for reaching out. Unfortunately I'm getting sick recently. Please allow me a few days before coming back.

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

@avr

Add AVR related definitions into QEMU, make AVR support buildable. [AM: Remove word 'Atmel' from filenames and all elements of code] Suggested-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com> Signed-off-by: Michael Rolnik <mrolnik@gmail.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> Signed-off-by: Thomas Huth <huth@tuxfamily.org> Message-Id: <20200705140315.260514-23-huth@tuxfamily.org> [PMD: Fixed @avr tag in qapi/machine.json] Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> (cherry picked from commit 42f3ff001339e37df4f13b709d2db00a488ee45c) Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

This is needed because the AVR CPU has separate code and data address spaces that both start from zero. Use 0x08000000 base for Flash memory and 0x00000000 base for CPU registers, IO registers and SRAM as the fast case. Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

Separate AVR architectures ("avr5", "avr51", "avr6", etc.) from actual MCU models. Only list the most representative MCU models. Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

This fixes CI tests on MingW64. Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

glennsec · 2025-01-17T19:18:51Z

Hi @wtdcode, I have fixed the new test failures wrt. the current dev branch. All tests now pass. Do you see anything left you would like me to change prior to committing the patchset to the dev branch? Thanks.

wtdcode · 2025-01-18T03:29:28Z

Hi @wtdcode, I have fixed the new test failures wrt. the current dev branch. All tests now pass. Do you see anything left you would like me to change prior to committing the patchset to the dev branch? Thanks.

Thanks for updates. This PR will go to 2.2.0 as mentioned in #2071 as I hope 2.1.2 to be released firstly to address a few urgent issues. I'm sorry for the delay as I'm busy with my academic matters.

Regarding the PR itself, I once quickly reviewed the code and I didn't see obvious flaws or request changes. The quality of integration is rather high and professional. I will take another look once 2.1.2 is out, which should happen shortly.

glennsec force-pushed the to_upstream/feature/avr branch from 3b071ab to 7c958ea Compare October 2, 2024 14:11

aquynh reviewed Oct 3, 2024

View reviewed changes

glennsec force-pushed the to_upstream/feature/avr branch from 7c958ea to ade427c Compare October 8, 2024 13:00

glennsec force-pushed the to_upstream/feature/avr branch from ade427c to 237c20e Compare October 22, 2024 13:04

glennsec force-pushed the to_upstream/feature/avr branch from 237c20e to 9a25b59 Compare October 22, 2024 14:41

glennsec and others added 13 commits January 17, 2025 14:13

Import AVR target from QEMU v5.2.0.

e24ac1d

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

qemu/target/avr: pregenerate decoder.

717a356

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

qemu/target/avr: pregenerate overrides (extern symbols).

5463d75

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

qemu/target/avr: add initial Unicorn integration.

ec99cf6

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

qemu/target/avr: add support for block and insn hooks.

33a6475

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

Add Unicorn/AVR support.

258707f

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: rework ARCH/CPU models.

8b999a4

Separate AVR architectures ("avr5", "avr51", "avr6", etc.) from actual MCU models. Only list the most representative MCU models. Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: add 16-bit & 32-bit register accessors.

5aa68f6

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: fix selection and validation of CPU model.

b0f2243

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

Add AVR code samples.

6c1e241

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

Add AVR unit tests.

5f64817

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

glennsec added 15 commits January 17, 2025 14:13

bindings: update const generator for AVR.

a33597b

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

bindings: regenerate constants for AVR support.

e35ef10

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

build: update build systems for AVR support.

f214053

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: drop built-in disassembler tools.

3fac14c

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: update for new v2.1.x APIs.

bc75094

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: fix cpu_reset() prototype.

30e359e

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: drop unused error_report() function override.

007075e

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: fix compilation on non-Linux platforms.

81292cc

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: move declarations at the begining of the function.

1256f79

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: mention new architecture into README.md.

8dd5ac9

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: add self to CREDITS.txt

88b5ac2

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: fix build with older compilers.

c19dc1c

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

bindings: add avr constants to python binding module.

063ed85

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

rust: add AVR architecture support.

ebf4bfb

Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

AVR: sync changes from "dev" branch (a78d690).

7fa65eb

This fixes CI tests on MingW64. Signed-off-by: Glenn Baker <glenn.baker@gmx.com>

glennsec force-pushed the to_upstream/feature/avr branch from 9a25b59 to 7fa65eb Compare January 17, 2025 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AVR support #2021

AVR support #2021

glennsec commented Oct 2, 2024

aquynh Oct 3, 2024

glennsec Oct 9, 2024

aquynh commented Oct 3, 2024

aquynh commented Oct 3, 2024

bet4it commented Oct 3, 2024

glennsec commented Oct 9, 2024

glennsec commented Oct 9, 2024

wtdcode commented Oct 10, 2024

glennsec commented Oct 11, 2024

glennsec commented Oct 11, 2024

glennsec commented Oct 22, 2024

wtdcode commented Oct 22, 2024

in7egral commented Nov 11, 2024

wtdcode commented Nov 11, 2024 •

edited

Loading

glennsec commented Jan 17, 2025

wtdcode commented Jan 18, 2025

AVR support #2021

Are you sure you want to change the base?

AVR support #2021

Conversation

glennsec commented Oct 2, 2024

aquynh Oct 3, 2024

Choose a reason for hiding this comment

glennsec Oct 9, 2024

Choose a reason for hiding this comment

aquynh commented Oct 3, 2024

aquynh commented Oct 3, 2024

bet4it commented Oct 3, 2024

glennsec commented Oct 9, 2024

glennsec commented Oct 9, 2024

wtdcode commented Oct 10, 2024

glennsec commented Oct 11, 2024

glennsec commented Oct 11, 2024

glennsec commented Oct 22, 2024

wtdcode commented Oct 22, 2024

in7egral commented Nov 11, 2024

wtdcode commented Nov 11, 2024 • edited Loading

glennsec commented Jan 17, 2025

wtdcode commented Jan 18, 2025

wtdcode commented Nov 11, 2024 •

edited

Loading