Skip to content

Commit

Permalink
chore: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jérôme Laban <jerome@platform.uno>
  • Loading branch information
dr1rrb and jeromelaban authored Jan 23, 2025
1 parent f44238b commit b608266
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ internal static class CompilationWorkspaceProvider
// https://github.com/dotnet/roslyn/blob/fc6e0c25277ff440ca7ded842ac60278ee6c9695/src/Features/Core/Portable/EditAndContinue/EditAndContinueService.cs#L72
Environment.SetEnvironmentVariable("Microsoft_CodeAnalysis_EditAndContinue_LogDir", logPath);

// Unconditionally enable binlog generation in msbuild. See https://github.com/dotnet/project-system/blob/4210ce79cfd35154dbd858f056bfb9101f290e69/docs/design-time-builds.md?L61

Check failure on line 34 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/MetadataUpdates/CompilationWorkspaceProvider.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 34 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/MetadataUpdates/CompilationWorkspaceProvider.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
Environment.SetEnvironmentVariable("MSBUILDDEBUGENGINE", "1");
Environment.SetEnvironmentVariable("MSBUILDDEBUGPATH", logPath);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,14 @@ private void InitializeInner(ConfigureServer configureServer) => _initializeTask
.MSBuildProperties
.ToDictionary();

// Flag the current build as created for hot reload, which allows for running targets or settings

Check failure on line 68 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 68 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
// props/items in the context of the hot reload workspace.

Check failure on line 69 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)

Check failure on line 69 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
properties["UnoIsHotReloadHost"] = "True";

Check failure on line 71 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
// Set the RuntimeIdentifier as a temporary property so that we do not force the
// property as a read-only global property that would be transitively applied to

Check failure on line 73 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
// projects that are not supporting the head's RuntimeIdentifier. (e.g. an android app

Check failure on line 74 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
// which references a netstd2.0 library project)

Check failure on line 75 in src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055)
if (properties.Remove("RuntimeIdentifier", out var runtimeIdentifier))
{
properties["UnoHotReloadRuntimeIdentifier"] = runtimeIdentifier;
Expand Down

0 comments on commit b608266

Please sign in to comment.