docs(UnoCTK)Added examples for usage of converters second try from initial #18726 #19086
Conversation
|
|
|
The reason the PR is failing is that it is missing the required colon (
should be: |
the documentation was only including UI things. Non-UI elements are slightly different and especially for beginners this example is expected to fill the missing piece in this topic and is expected to improve the learning curve, because they can see how to implement this different two types (UI and Non-UI). Also added the Link to the CommunityToolkit Documentation, so its easyer to find similar Non-UI tools.
MartinZikmund
force-pushed
the
DevTKSSdocs(CTKConvertersUpdate)
branch
from
e4fa1e7 to
3b9648e
Compare
|
@DevTKSS I have rebased and force pushed the branch to fix the commit message, just make sure the colon is there next time 👍 |
|
|
|
There are some trailing spaces that should not be in the .md file:
|
Deleted duplicated link to get-help.md at line281-284
|
@MartinZikmund checked the depending line and deleted also a duplicated link at the end of the file |
|
|
|
|
|
dont know how i can fit the past commit strings to match the pattern... in visual studio "correct" and push seems to not do anything... |
|
|
|
|
|
@MartinZikmund seems like that commit message which I am not able to edit is the last thing blocking this. one of them seems to have no changes, but everytime I am trying to "correct" this, its resetting ALL changes after this commit intead of changing just that text in the commit. |
|
|
|
these two commits need to be reworded to be |
MartinZikmund
force-pushed
the
DevTKSSdocs(CTKConvertersUpdate)
branch
from
2ac36ba to
4bd82cd
Compare
Deleted duplicated link to get-help.md at line281-284
MartinZikmund
force-pushed
the
DevTKSSdocs(CTKConvertersUpdate)
branch
from
4bd82cd to
f125f26
Compare
|
I have reworded and rebased the commits, should be good again now |
|
|
…/DevTKSS/uno into DevTKSSdocs(CTKConvertersUpdate)
|
dont know what github desktop did... opened code in vs 2022 which seems to dislike git really, so it stated I would not be able to just pull that repo down to update local files... github desktop automatically fetched (is that rebasing? that desktop thing is not understandable to me... new words online was not using...) then a button on the top appeared which (to me) seemed to tell to merge the online to my local repo... but then after this it suddenly did some push... Did it just reset what you did or what was that... on the last commit to that time the only changes I am seeing it told has been updated are adding two xml tags on the fenced code... |
|
|
|
|
|
so, in vs 2022 I did reset with --mixed to have the changes applyed while the commit messages with issues should have been deleted. should all be merged at the last commit. vs studio seems to have not the same tools as vs code. Normally in my opinion reverting these message issueing commits with having the changes should satisfy the bash, but seems like its not. hoping it is at least satisfyed with the code itself? |
|
|
|
@DevTKSS if you don't manage to rewrite your history, squash it, it may be easier for you but in all cases we need the commit texts to be adjusted for this PR to move forward. Thanks! |
Link to first try PR
Do I really need to write all text again?