Input event Timestamp should be in microseconds
#19147
Open
+176
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/wasm 🌐
MartinZikmund
force-pushed
the
dev/mazi/timestamp-pointerpoint
branch
from
d89af73 to
d381d61
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html |
spouliot
reviewed
Jan 3, 2025
github-actions
bot
added
the
area/automation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html |
MartinZikmund
force-pushed
the
dev/mazi/timestamp-pointerpoint
branch
from
571c30e to
0ab0b79
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html |
dr1rrb
approved these changes
Jan 8, 2025
| var point = new PointerPoint( | ||
| frameId: (uint)data.time, // UNO TODO: How should we set the frame, timestamp may overflow. | ||
| timestamp: (uint)(data.time * TimeSpan.TicksPerMillisecond), // Time is given in milliseconds since system boot. See also: https://github.com/unoplatform/uno/issues/14535 | ||
| PointerDevice.For(data.evtype is XiEventType.XI_TouchBegin or XiEventType.XI_TouchEnd or XiEventType.XI_TouchUpdate ? PointerDeviceType.Touch : PointerDeviceType.Mouse), | ||
| timestamp: timeInMicroseconds, PointerDevice.For(data.evtype is XiEventType.XI_TouchBegin or XiEventType.XI_TouchEnd or XiEventType.XI_TouchUpdate ? PointerDeviceType.Touch : PointerDeviceType.Mouse), |
There was a problem hiding this comment.
Suggested change
| timestamp: timeInMicroseconds, PointerDevice.For(data.evtype is XiEventType.XI_TouchBegin or XiEventType.XI_TouchEnd or XiEventType.XI_TouchUpdate ? PointerDeviceType.Touch : PointerDeviceType.Mouse), | |
| timestamp: timeInMicroseconds, | |
| PointerDevice.For(data.evtype is XiEventType.XI_TouchBegin or XiEventType.XI_TouchEnd or XiEventType.XI_TouchUpdate ? PointerDeviceType.Touch : PointerDeviceType.Mouse), |
| /// Retrieves the relative timestamp in microseconds. | ||
| /// </summary> | ||
| /// <returns>Timestamp in microseconds.</returns> | ||
| internal static ulong GetRelativeTimestamp() => |
There was a problem hiding this comment.
Relative to what ? (It can be just in the comment IMO)
There was a problem hiding this comment.
BTW I realized that I didn't saw any usage of this. If this still use-full?
There was a problem hiding this comment.
Yes, no longer needed, will remove
| _bootTime ??= DateTime.UtcNow.Ticks - (long)(TimeSpan.TicksPerSecond * new NSProcessInfo().SystemUptime); | ||
|
|
||
| return (ulong)_bootTime.Value + (ulong)(TimeSpan.TicksPerSecond * timestamp); | ||
| // iOS Timestamp is in seconds from boot time. |
There was a problem hiding this comment.
This was to patch something like the timestamp being "paused" when the app was not in foreground (if I've good memory). Did you look in the history why it has been added and confirmed that it's no longer needed?
|
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19147/index.html |
MartinZikmund
force-pushed
the
dev/mazi/timestamp-pointerpoint
branch
from
3c6b663 to
d211256
Compare
MartinZikmund
force-pushed
the
dev/mazi/timestamp-pointerpoint
branch
from
d211256 to
ae1a42d
Compare
spouliot
reviewed
Jan 8, 2025
| @@ -7,7 +7,8 @@ | |||
| static UNOApplicationDelegate *ad; | |||
| static system_theme_change_fn_ptr system_theme_change; | |||
| static id<MTLDevice> device; | |||
| static NSTimeInterval uptime = 0; | |||
| static NSTimeInterval initialUptime = 0; | |||
| static NSDate *initialUptimeDate = nil; | |||
There was a problem hiding this comment.
those 2 variables do not seem needed anymore
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19147/index.html |
|
The build 151356 found UI Test snapshots differences: Details
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #14535
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):