fix: Ensure x:Uid is set only when both name and namespace are correct #19148
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/code-generation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19148/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19148/index.html |
|
|
Youssef1313
reviewed
Jan 3, 2025
| @@ -3328,7 +3328,8 @@ private void BuildExtendedProperties(IIndentedStringBuilder outerwriter, XamlObj | |||
| { | |||
| writer.AppendLineInvariantIndented("// Load {0}", member.Value); | |||
| } | |||
| else if (member.Member.Name == "Uid") | |||
| else if (member.Member.Name == "Uid" | |||
There was a problem hiding this comment.
This might need to be fixed as well:
There was a problem hiding this comment.
It should be var localizedObject = FindMember(objectDefinition, "Uid", XamlConstants.XamlXmlNamespace)
A test that covers the code path I mentioned may be needed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #19069
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a custom attached property with the name
Uidis attached to an element,x:Uidmight be associated with the target instead. This occurs becausex:Uidis linked to an element solely by its name, not by both name and namespace.What is the new behavior?
x:Uidwon't be linked to an element unless both name and namespace are correctPR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):