Skip to content

chore: Porting AnimatedVisualPlayer

Codacy Production / Codacy Static Code Analysis succeeded Jan 23, 2025 in 0s

Your pull request is up to standards!

Codacy found no issues in your code

Annotations

Check warning on line 19 in src/Uno.UI.Composition/Composition/CompositionPathGeometry.skia.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Composition/CompositionPathGeometry.skia.cs#L19 

Make '_commands' 'readonly'.

Check warning on line 17 in src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs#L17 

Make '_geometry' 'readonly'.

Check warning on line 67 in src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs#L67 

Make '_commands' 'readonly'.

Check warning on line 90 in src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs#L90 

Make '_rect' 'readonly'.

Check warning on line 99 in src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs#L99 

Make '_rect' 'readonly'.

Check warning on line 108 in src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasGeometry.cs#L108 

Make '_ellipse' 'readonly'.

Check warning on line 20 in src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasPathBuilder.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI.Composition/Win2D/Microsoft/Graphics/Canvas/Geometry/CanvasPathBuilder.cs#L20 

Make '_commands' 'readonly'.

Check warning on line 35 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.h.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.h.mux.cs#L35 

Make 'm_suspendingRevoker' 'readonly'.

Check warning on line 37 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.h.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.h.mux.cs#L37 

Make 'm_xamlRootChangedRevoker' 'readonly'.

Check warning on line 39 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.h.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.h.mux.cs#L39 

Make 'm_unloadedRevoker' 'readonly'.

Check warning on line 48 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L48 

Remove this commented out code.

Check warning on line 283 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L283 

Remove this useless assignment to local variable 'me'.

Check notice on line 290 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L290 

Remove this empty statement.

Check warning on line 323 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L323 

Remove this commented out code.

Check warning on line 345 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L345 

This line will not be executed conditionally; only the first line of this 2-line block will be. The rest will execute unconditionally.

Check warning on line 525 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L525 

Remove this useless assignment to local variable 'measuredSize'.

Check notice on line 526 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L526 

Remove the unused local variable 'widthScale'.

Check notice on line 527 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L527 

Remove the unused local variable 'heightScale'.

Check notice on line 527 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L527 

Remove this empty statement.

Check notice on line 534 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L534 

Remove this empty statement.

Check notice on line 735 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L735 

Remove the unused local variable 'calling_thread'.

Check notice on line 739 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L739 

Remove the unused local variable 'thisPlay'.

Check notice on line 822 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L822 

Remove the unused local variable 'ignore'.

Check failure on line 893 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L893 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 895 in src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/Uno.UI/Microsoft/UI/Xaml/Controls/AnimatedVisualPlayer/AnimatedVisualPlayer.mux.cs#L895 

Add curly braces around the nested statement(s) in this 'if' block.
View more details on Codacy Production