Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: deprecation on getWithDefault #15

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fixed: deprecation on getWithDefault #15

merged 1 commit into from
Nov 8, 2024

Conversation

nathalieArnoux
Copy link
Contributor

What does this PR do?

Replaced deprecated method getWithDefault.

Related to: #VEL-3592

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

@nathalieArnoux nathalieArnoux self-assigned this Nov 6, 2024
@nathalieArnoux nathalieArnoux requested review from Miexil, phndiaye and a team as code owners November 6, 2024 10:15
@nathalieArnoux nathalieArnoux requested review from OwenCoogan and removed request for a team November 6, 2024 10:15
Copy link

linear bot commented Nov 6, 2024

@nathalieArnoux nathalieArnoux merged commit d82178e into main Nov 8, 2024
3 checks passed
@nathalieArnoux nathalieArnoux deleted the na/VEL-3592 branch November 8, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants