Doco updates and questions #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
suggested changes
Dec 9, 2016
| * To push your image to docker hub, set $PREFIX to your account name, then `make push` | ||
|
|
||
| ## Get Started | ||
| 1. Create auth tokens file (how?) |
There was a problem hiding this comment.
Tokens can be whatever length or format you would like, I typically just generate a random string .
There was a problem hiding this comment.
excellent, thanks for confirming. I'll update with a "generate a SHA-1" one-liner.
| * docker-registry: Set to url of private docker registry | ||
| * template-namespace: Namespace to 'clone from when creating new deployments' | ||
| * path-to-tokens: Full path including file name to tokens file for authorization, setting to empty string will disable. | ||
|
|
||
| ## Building | ||
|
|
||
| * Install Go |
There was a problem hiding this comment.
linked to the getting started/install stuff
|
I added an example token generation step, then deployed the secret and the rc spec to my k8s cluster. looking good so far. moving onto the services. |
|
Awesome! Thanks so much for this! Would you mind rebasing + squashing down before merging? |
|
I did rebase. I think you can alter the commits if you like. I commit a lot. It's a habit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting set up with your awesome project. Shuffles some things around in the docs, asked some questions. Open to answers as review.