Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp dev setup to match production environment #75

Open
wants to merge 1 commit into
base: dev/gdsc-open-source-2022
Choose a base branch
from

Conversation

embeddedt
Copy link

@embeddedt embeddedt commented Oct 10, 2022

This is intended to fix #68. A new devproxy container is added that runs Apache and sits in front of the existing Nginx proxy. (This is technically redundant, but it matches the production environment, as far as I know.)

I gave up on trying to get Shibboleth to work. It's very picky about the server name in order to work properly, and I didn't think it was worth investing more than the 2 hours I had spent. So, I just hardcoded a utorid into the Apache configuration so that it mimics the behavior of the real Shibboleth proxy. I think this is good enough for now, but happy to hear other opinions.

As a result of these changes, the entire dev environment is now run inside Docker Compose as well, using a special command to load the development yml file instead of the production one. Thus, no manual changes are required after cloning to have a fully working setup. 🎉

I'm opening this as a starting point for further discussion on how we want this to look, so it's a draft for now.

@huonggiangbui huonggiangbui requested review from hiimchrislim and removed request for hiimchrislim October 10, 2022 22:48
@embeddedt embeddedt marked this pull request as ready for review December 23, 2022 19:40
@hiimchrislim
Copy link
Member

I would add this as a separate setup on the readme rather than removing the local dev setup. Containerizing everything gets tedious and slows dev work when debugging/making changes. Even with remote debugging, making changes and recompiling them takes a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants