Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCSS-99: Replace/remove loading spinner on homepage #103

Merged
merged 1 commit into from
Oct 19, 2024
Merged

MCSS-99: Replace/remove loading spinner on homepage #103

merged 1 commit into from
Oct 19, 2024

Conversation

renee-k
Copy link
Contributor

@renee-k renee-k commented Oct 6, 2024

What's Inside

  • [ Replaced the loading spinner with a static one]

static_spinner

@renee-k renee-k requested a review from a team as a code owner October 6, 2024 05:20
@netlify Netlify
Copy link

netlify bot commented Oct 6, 2024 •
edited
Loading

✅ Deploy Preview for mcss-website ready!

Name Link
🔨 Latest commit 83244ac
🔍 Latest deploy log https://app.netlify.com/sites/mcss-website/deploys/67021e042808240008a6d872
😎 Deploy Preview https://deploy-preview-103--mcss-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93
Accessibility: 84
Best Practices: 100
SEO: 86
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@renee-k renee-k linked an issue Oct 6, 2024 that may be closed by this pull request
Replace/remove loading spinner on homepage #99
Closed
nxabdullah
nxabdullah approved these changes Oct 16, 2024
View reviewed changes
Copy link

@nxabdullah nxabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renee-k renee-k merged commit 31d5253 into master Oct 19, 2024
5 checks passed
@renee-k renee-k deleted the 99-replace-loading-spinner branch October 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxabdullah nxabdullah nxabdullah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace/remove loading spinner on homepage
2 participants
@renee-k @nxabdullah