Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DASHBOARD_COLUMNS to config, with defaults to match current COSRI #156

Merged
merged 10 commits into from
Nov 15, 2022

Conversation

pbugni
Copy link
Contributor

@pbugni pbugni commented Oct 19, 2022

First step in implementing #143.

Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Let me know if the linter ever becomes too much. Looks like we can configure it auto-fix, if that's of interest

@pbugni
Copy link
Contributor Author

pbugni commented Oct 20, 2022

Looks good!

Let me know if the linter ever becomes too much. Looks like we can configure it auto-fix, if that's of interest

i really like having the linters enabled. good to know auto-fix is an option, not ready for that, yet :)

},
{
"label": "Birth Date",
"expr": "$.birthdate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbugni I think this should be $.birthDate (FHIR patient reference)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've found HAPI is inconsistent with the case of birthDate, anyhow, thanks for the request, I'm guessing it didn't work as was...

Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/test_columnconfig/patient_bundle.json Show resolved Hide resolved
* display custom columns

* remove un-intended changes

* re-code queries

* remove un-needed code

* remove extra line

* Update PatientListTable.js

* add count param

Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
patientsearch/config.py Outdated Show resolved Hide resolved
@pbugni pbugni marked this pull request as ready for review November 15, 2022 23:00
@pbugni pbugni merged commit f96294a into develop Nov 15, 2022
@pbugni pbugni deleted the feature/customize-columns branch November 15, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants