-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display custom columns #158
display custom columns #158
Conversation
We decided to populate these fields, have them all sortable except for "last assessed", since that's very tricky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good solution, thanks @achen2401
…wcirg/cosri-patientsearch into feature/display-custom-columns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
…RI (#156) * Add `DASHBOARD_COLUMNS` to config, with defaults to match current COSRI * whitespace - keep linter happy :) * more lint cleanup * correct case of `birthDate` to fit FHIR patient spec * Adding test files for extraction of referenced resources * formatting to keep black happy. * display custom columns (#158) * display custom columns * remove un-intended changes * re-code queries * remove un-needed code * remove extra line * Update PatientListTable.js * add count param Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu> * error check for dashboard column config * Need to load DASHBOARD_COLUMNS as JSON. * Black whitespace fix. Co-authored-by: Paul F Bugni <pbugni@uw.edu> Co-authored-by: Amy Chen <achen2401@gmail.com> Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
Part of #143
allow configurations of custom columns.
A config,
FHIR_REST_EXTRA_PARAMS_LIST
is added to allow specification of additional FHIR resource(s) needed for each patient.For instance, tried, for DCW:
FHIR_REST_EXTRA_PARAMS_LIST = os.getenv("FHIR_REST_EXTRA_PARAMS_LIST", ["QuestionnaireResponse?_elements=resourceType,authored,subject&_sort=-authored"])
Note, I tried
_revinclude
parameter to include additional resources, example. However, including such parameter returns a flat array of Patient resources and other resources, which I fear may mess up paging. Another issue with using_revinclude
or_include
parameters to query for additional FHIR resources for the patient is that one cannot seem to sort the additionally included resource(s). This is problematic if sorting the additional results is important (e.g. for DCW, to obtain last assessed date, one needs to sort the questionnaireResponses by authored date in descending order).As a consequence, it seems the frontend needs to separately query for additional needed resources.
Also noting that sorting by Last Assessed doesn't seem feasible via FHIR query when combined with
Patient
resources and sorting by MRN will only show the ones that have relevant FHIR identifier (ones that don't won't show)