python 3.7 fell off EOL. upgrade to 3.11 #237
Conversation
DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated
max-line-length
This reverts commit 6ea1493.
pyproject.toml
Outdated
| @@ -0,0 +1,40 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=42", "wheel", "setuptools_scm"] | |||
There was a problem hiding this comment.
setuptools_scm could probably be removed, but no strong feelings.
We used setuptools_scm in the portal too, but I haven't included it in any new projects. We don't often distribute our projects as modules to include elsewhere, so there isn't much value in python/pip being able to distinguish different versions.
| requires = ["setuptools>=42", "wheel", "setuptools_scm"] | |
| requires = ["setuptools>=42", "wheel"] |
tox.ini
Outdated
| @@ -1,5 +1,5 @@ | |||
| [tox] | |||
| envlist = py3 | |||
| envlist = py311 | |||
There was a problem hiding this comment.
Minor nitpick; shouldn't matter either way:
I don't think this will do anything without also specifying basepython eg basepython = python3.11.
Tox can't install python, so if the required basepython is missing it will fail. This isn't a big deal for CI since we always keep them aligned, but it may make it difficult for devs to run tests locally if their machine doesn't have the exact same interpreter version.
| envlist = py311 | |
| envlist = py3 |
There was a problem hiding this comment.
ah yes, that was a failed attempt at working around the wrong version of py - fixed elsewhere
reverting this change, thank you.
No longer able to build based on python 3.7
Leaping to 3.11
Deprecation errors forcing move from
setup.{cfg,py}topyproject.toml. See PEPs 517 and 518